-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding value to where in toolGetMapping #405
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=========================================
- Coverage 0.00% 0.00% -0.01%
=========================================
Files 266 266
Lines 17109 17152 +43
=========================================
Hits 1 1
- Misses 17108 17151 +43
☔ View full report in Codecov by Sentry. |
Did you try that input data generation is still working? Did you compare old and new input data and ensured that they are the same? |
R/calcAGEB.R
Outdated
@@ -15,7 +15,7 @@ | |||
calcAGEB <- function(subtype = "balances") { | |||
ageb <- readSource("AGEB", subtype = subtype) | |||
|
|||
mapping <- toolGetMapping("Mapping_AGEB_REMIND.csv", type = "reportingVariables") %>% | |||
mapping <- toolGetMapping("Mapping_AGEB_REMIND.csv", type = "reportingVariables", where="mappingfolder") %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that your added code does not produce linter warnings. This addition should cause a complaint about missing whitespaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Comparison: |
did you check that you are not generating linter warnings? |
A 0.2 % increase. |
Not what I would have expected under a "fixed lintr warnings" commit, and somewhat obfuscating the commit history. $ git diff --ignore-all-space -U0 c09aea9~ -- R/read*
diff --git a/R/readExpertGuess.R b/R/readExpertGuess.R
index 04b18a4..9057ff8 100644
--- a/R/readExpertGuess.R
+++ b/R/readExpertGuess.R
@@ -40 +40 @@ readExpertGuess <- function(subtype) {
- a <- read.csv("co2prices.csv", sep = ";")
+ a <- read.csv("co2prices-2023-06.csv", sep = ";")
diff --git a/R/readUNFCCC_NDC.R b/R/readUNFCCC_NDC.R
index b9fa3ed..9a2850c 100644
--- a/R/readUNFCCC_NDC.R
+++ b/R/readUNFCCC_NDC.R
@@ -21 +21 @@ readUNFCCC_NDC <- function(subtype) {
- NDCfile <- "NDC_2023-02-24.xlsx"
+ NDCfile <- "NDC_2023-05-31.xlsx" Would have appreciated a |
They very much are, because
|
Ok, I see. Not good. |
But not terrible, either. Just inconvenient.
No.
You cannot change the history of a public repository without calling down the ire of the git gods upon yourself. Clarification: the problem is that the commit history looks wonky. So "fixing the problem" would be by definition sacrilegious. But it is a "avoid this in the future" problem. |
Went through all warnings displayed by
reposearch toolGetMapping
inmrremind
and adjusted thewhere
value.